xfail very flaky test

[max-sixty]

This consistently fails.

In general I think as soon as we see this happening, we should either fix immediately (but probably not that easy) or xfail it and if necessary open an issue. That keeps the main branch green, such that we can reliably use passing tests as an indicator of PRs.

Though as ever, very open to other thoughts. There's a reasonable argument that "keeping master green by removing any failing tests is missing the point a bit"...

[max-sixty]

I think this is wrong and it's actually these?

=========================== short test summary info ============================
FAILED xarray/tests/test_backends.py::TestPydapOnline::test_cmp_local_file - ...
FAILED xarray/tests/test_backends.py::TestPydapOnline::test_dask - webob.exc....
FAILED xarray/tests/test_backends.py::TestPydapOnline::test_compatible_to_netcdf

[shoyer]

In general I think as soon as we see this happening, we should either fix immediately (but probably not that easy) or xfail it and if necessary open an issue. That keeps the main branch green, such that we can reliably use passing tests as an indicator of PRs.

Though as ever, very open to other thoughts. There's a reasonable argument that "keeping master green by removing any failing tests is missing the point a bit"...

👍

It does look like the "TestPydapOnline" tests are still a culprit here...

[max-sixty]

It does seem this is happening a fair amount, so I'll merge this — feel free to revert if I'm mistaken. I think it may be worth also xfailing the Pydap tests?