Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link maintenance #5182

Merged
merged 11 commits into from
Apr 19, 2021
Merged

link maintenance #5182

merged 11 commits into from
Apr 19, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Apr 17, 2021

This fixes a few broken links in our RST files and moves a few links.

Note that the module referenced here:

If you support more complex indexing as `explicit indexing` or
`numpy indexing`, you can have a look to the implemetation of Zarr backend and Scipy backend,
currently available in :py:mod:`~xarray.backends` module.

does not have a API page, yet. Should we try to fix that, or would linking to github be better? Also, were the explicit indexing and numpy indexing meant to be links or literal text?

  • Passes pre-commit run --all-files

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keewis !

@dcherian
Copy link
Contributor

Thanks @keewis

@keewis
Copy link
Collaborator Author

keewis commented Apr 19, 2021

thanks for the reviews, @max-sixty, @dcherian

@keewis keewis merged commit 5b2257e into pydata:master Apr 19, 2021
@keewis keewis deleted the fix-links branch April 19, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants