Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ._replace rather than reconstructing vars #5181

Merged
merged 2 commits into from
Apr 18, 2021

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Apr 17, 2021

  • Passes pre-commit run --all-files

I saw a few of these while looking through the code — generally we're using ._replace now, so this grows that convention to variable.py too. It was a regex replace but I took a look through to confirm. And fixed one mypy error which the change caught.

@max-sixty max-sixty merged commit e0358e5 into pydata:master Apr 18, 2021
@max-sixty max-sixty deleted the variable-replace branch April 18, 2021 22:12
@max-sixty max-sixty restored the variable-replace branch April 19, 2021 06:05
@max-sixty max-sixty deleted the variable-replace branch April 19, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants