Do not write an empty "coordinates" attribute to a netCDF file#5121
Merged
dcherian merged 4 commits intopydata:masterfrom Apr 7, 2021
bopen:drop_empty_coordinates_attribute
Merged
Do not write an empty "coordinates" attribute to a netCDF file#5121dcherian merged 4 commits intopydata:masterfrom bopen:drop_empty_coordinates_attribute
dcherian merged 4 commits intopydata:masterfrom
bopen:drop_empty_coordinates_attribute
Conversation
keewis
approved these changes
Apr 7, 2021
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
looks good to me. We could change the comparison, but this doesn't really change the readability so it's your choice. I don't know much about the current behavior so I can't comment on changing the test vs. writing a new one.
Co-authored-by: keewis <keewis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behaviour is not too problematic as CF checkers don't complain about the empty string, but it is aesthetically annoying.
This happens more frequently after #2844 added the auxiliary variable to
.coords.