Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface plots #5101

Merged
merged 33 commits into from
May 3, 2021
Merged

Surface plots #5101

merged 33 commits into from
May 3, 2021

Commits on Mar 31, 2021

  1. Use broadcast_like for 2d plot coordinates 

    Use broadcast_like if either `x` or `y` inputs are 2d to ensure that
both have dimensions in the same order as the DataArray being plotted.
Convert to numpy arrays after possibly using broadcast_like. Simplifies
code, and fixes pydata#5097 (bug when dimensions have the same size).
    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    3ad10d9 View commit details
    Browse the repository at this point in the history

  2. Update whats-new

    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    17151d1 View commit details
    Browse the repository at this point in the history

  3. Implement 'surface()' plot function 

    Wraps mpl_toolkits.mplot3d.axes3d.plot_surface
    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    38220a6 View commit details
    Browse the repository at this point in the history

  4. Make surface plots work with facet grids

    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    0ce6941 View commit details
    Browse the repository at this point in the history

  5. Unit tests for surface plot

    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    c7dbdf1 View commit details
    Browse the repository at this point in the history

  6. Minor fixes for surface plots

    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    bc0c85a View commit details
    Browse the repository at this point in the history

  7. Add surface plots to api.rst and api-hidden.rst

    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    d31e193 View commit details
    Browse the repository at this point in the history

  8. Update whats-new

    @johnomotani
    johnomotani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    7acce7e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Fix tests

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    1e4ff18 View commit details
    Browse the repository at this point in the history

  2. mypy fix

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    e12b7ce View commit details
    Browse the repository at this point in the history

  3. seaborn doesn't work with matplotlib 3d toolkit

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    266bd4a View commit details
    Browse the repository at this point in the history

  4. Remove cfdatetime surface plot test 

    Does not work because the datetime.timedelta does not work with
surface's 'shading'.
    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    e3de64f View commit details
    Browse the repository at this point in the history

  5. Ignore type checks for mpl_toolkits module

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    82c708e View commit details
    Browse the repository at this point in the history

  6. Check matplotlib version is new enough for surface plots

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    f27aa45 View commit details
    Browse the repository at this point in the history

  7. version check requires matplotlib

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    b0a1f40 View commit details
    Browse the repository at this point in the history

  8. Handle matplotlib not installed for TestSurface version check

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    e592e5e View commit details
    Browse the repository at this point in the history

  9. fix flake8 error

    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    43a51e9 View commit details
    Browse the repository at this point in the history

  10. Don't run test_plot_transposed_nondim_coord for surface plots 

    Too complicated to check matplotlib version is high enough just for
surface plots.
    @johnomotani
    johnomotani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    ea43177 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
    @johnomotani @mathause
    johnomotani and mathause authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    648e13b View commit details
    Browse the repository at this point in the history

  2. More suggestions from code review

    @johnomotani
    johnomotani committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    313daf0 View commit details
    Browse the repository at this point in the history

  3. black

    @johnomotani
    johnomotani committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    a566744 View commit details
    Browse the repository at this point in the history

  4. isort and flake8

    @johnomotani
    johnomotani committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    817d305 View commit details
    Browse the repository at this point in the history

  5. Make surface plots more backward compatible 

    Following suggestion from Illviljan
    @johnomotani
    johnomotani committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    99459cc View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Clean up matplotlib requirement

    @johnomotani
    johnomotani committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    f86f76d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Update xarray/plot/plot.py 

    Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
    @johnomotani @mathause
    johnomotani and mathause authored Apr 27, 2021
    Configuration menu
    Copy the full SHA
    7b6f470 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into surface-plots

    @johnomotani
    johnomotani committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    efdc140 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
    @johnomotani @mathause
    johnomotani and mathause authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    518110c View commit details
    Browse the repository at this point in the history

  2. Use None as default value

    @johnomotani
    johnomotani committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    84b3e6d View commit details
    Browse the repository at this point in the history

  3. black

    @johnomotani
    johnomotani committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    08b9117 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. More 2D plotting method examples in docs

    @johnomotani
    johnomotani committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    c964848 View commit details
    Browse the repository at this point in the history

  2. Fix docs

    @johnomotani
    johnomotani committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    50152b3 View commit details
    Browse the repository at this point in the history

  3. [skip-ci] Make example surface plot look a bit nicer

    @johnomotani
    johnomotani committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4831b8b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Merge branch 'master' into surface-plots

    @mathause
    mathause committed May 3, 2021
    Configuration menu
    Copy the full SHA
    cf9c49a View commit details
    Browse the repository at this point in the history