ensure combine_by_coords raises on different types #5090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
No that does not work either because this raises on string coordinates. |
mathause
changed the title
spencerkclark
approved these changes
Mar 31, 2021
Member
There was a problem hiding this comment.
This looks good to me -- thanks @mathause.
When we address #4853 we may need to adapt this logic again -- there we could have dates with different calendars but the same type -- but I think we can cross that bridge when we get there. We rely on the "different calendar implies different type" assumption in other places in the code as well.
Collaborator
Author
|
You mean that cftime.DatetimeNoLeap(2000, 1, 5) == cftime.datetime(2000, 1, 5, calendar="noleap")? Yes that could be inconvenient but possible... Well yes, let's fix that once we have to... |
Member
|
@mathause yes, exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files