-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more tutorial refactoring #5074
Conversation
I decided to also make This should be ready to merge as is (once the tests pass) but the dataset descriptions still need to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug through the history of xarray-data
and tried to add a description for all datasets but I'm not sure I got everything right. If I did this should be ready for a final review and then merging.
ping. Should we try to silence the
warning? Otherwise this should be ready for merging (but please do check the dataset descriptions, I'm really not sure about those). |
Yes, we should silence this! And maybe make a feature request to Pooch
…On Sat, Apr 17, 2021 at 3:15 PM keewis ***@***.***> wrote:
ping. Should we try to silence the
Use this value as the 'known_hash' argument of 'pooch.retrieve' to ensure that the file hasn't changed if it is downloaded again in the future.
warning? Otherwise this should be ready for merging (but please do check
the dataset descriptions, I'm really not sure about those).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5074 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJFVST2EEKN3D4WK5EZQLTJIB77ANCNFSM4ZYJDKPQ>
.
|
how, exactly? I can probably add a |
see here for an example: https://docs.python.org/3/library/warnings.html#temporarily-suppressing-warnings |
oh, sorry. I actually meant to ask whether I should use the way recommend by Edit: actually, that's not a warning: it seems that's a |
We could do something like, which is a bit overbearing, but would solve this until it's unblocked by pooch: logging.getLogger("google.cloud.bigquery.opentelemetry_tracing").setLevel(
logging.CRITICAL
) (there may well be ways of doing this only within our execution, which we could do if this is a long-term solution) |
Pooch really shouldn't be registering it's own logger, since it's a library not an application: fatiando/pooch#232 That said, for now I agree with @max-sixty's recommendation. It's recommended in the Pooch docs, too: |
I didn't see that part of the documentation, this should be fixed now. Thanks for the hints, @max-sixty, @shoyer. |
we have to make sure to deprecate / remove |
follow-up to #4102. This reverts the combination of
tutorial.open_dataset
andtutorial.open_rasterio
(the concept oftutorial.open_*
is "cached download+open_*"), and updates the tests to not depend on a environment variable (which makes the tests also run on macos and windows).In #4102 I added a list of available datasets, but it would be good to add a small description. I still need descriptions for:
air_temperature
rasm
ROMS_example
era5-2mt-2019-03-uk.grib
RGB.byte
(the readme says "derived from USGS Landsat 7 ETM imagery")pre-commit run --all-files
whats-new.rst