Skip to content

install the dev version of sparse in the upstream-dev CI #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2021
Merged

install the dev version of sparse in the upstream-dev CI #5059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8636d05
re-enable sparse [test-upstream]
keewis Mar 20, 2021
358aeff
remove the comment about adding sparse back in
keewis Mar 20, 2021
2204d6b
silence the failing test for now [test-upstream]
keewis Mar 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ci/install-upstream-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
#!/usr/bin/env bash

# TODO: add sparse back in, once Numba works with the development version of
# NumPy again: https://github.com/pydata/xarray/issues/4146

conda uninstall -y --force \
numpy \
scipy \
Expand Down Expand Up @@ -42,5 +39,5 @@ python -m pip install \
git+https://github.com/Unidata/cftime \
git+https://github.com/mapbox/rasterio \
git+https://github.com/hgrecco/pint \
git+https://github.com/pydata/bottleneck # \
# git+https://github.com/pydata/sparse
git+https://github.com/pydata/bottleneck \
git+https://github.com/pydata/sparse
4 changes: 4 additions & 0 deletions xarray/tests/test_sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,10 @@ def test_variable_method(func, sparse_output):
ret_s = func(var_s)
ret_d = func(var_d)

# TODO: figure out how to verify the results of each method
if isinstance(ret_d, xr.Variable) and isinstance(ret_d.data, sparse.SparseArray):
ret_d = ret_d.copy(data=ret_d.data.todense())

if sparse_output:
assert isinstance(ret_s.data, sparse.SparseArray)
assert np.allclose(ret_s.data.todense(), ret_d.data, equal_nan=True)
Expand Down