-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods #4939
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5b30f5c
Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods
spencerkclark a734b42
Address review comments
spencerkclark 5bdcb46
Add new methods to api-hidden.rst
spencerkclark 2e029ca
Fix docstring
spencerkclark bd8050b
Fix docstring
spencerkclark 798f673
lint
spencerkclark e9414d2
More docstring formatting
spencerkclark b977701
Update xarray/core/rolling.py
spencerkclark 7015524
Fix what's new link
spencerkclark 0306746
Update xarray/core/rolling.py
spencerkclark 8416383
Update xarray/core/rolling.py
spencerkclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think docstrings are in rst format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on this, and eventually opted to keep things as they were. This is consistent with the other docstrings for rolling and coarsening objects. I don't have a strong opinion though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One backtick seems to render as italics and two as code block. In text form I also like the single backticks more. I am fine to leave as is.
https://xray--4939.org.readthedocs.build/en/4939/generated/xarray.core.rolling.DataArrayCoarsen.reduce.html#xarray.core.rolling.DataArrayCoarsen.reduce
https://xray--4939.org.readthedocs.build/en/4939/generated/xarray.core.weighted.DataArrayWeighted.mean.html