update pre-commit hooks

[keewis]

I issued a bugfix release for the issue detected in #4810 (comment), so we should use that. pre-commit autoupdate also tried to update to mypy=v0.800, but this fails because mypy does not like the redefinition of dask_array_type (and the other *_type variables in xarray.core.pycompat):

xarray/core/pycompat.py:19: error: Incompatible types in assignment (expression has type "Tuple[]", variable has type "Tuple[Any]")
xarray/core/pycompat.py:29: error: Incompatible types in assignment (expression has type "Tuple[]", variable has type "Tuple[Any]")
xarray/core/pycompat.py:37: error: Incompatible types in assignment (expression has type "Tuple[]", variable has type "Tuple[Any]")

Does anyone know how to fix that?

• Passes pre-commit run --all-files

[mathause]

I am super confused... These errors should be ignored I think:

xarray/setup.cfg

Lines 232 to 233 in 110c857

	[mypy-xarray.core.pycompat]
	ignore_errors = True

Also I get other errors when running mypy xarray (a lot of them:

xarray/core/pycompat.py:10: error: Skipping analyzing 'dask.array': found module but no type hints or library stubs

Somehow it does not recognize the wildcard - don't you get this?

xarray/setup.cfg

Lines 182 to 183 in 110c857

	[mypy-dask.*]
	ignore_missing_imports = True

(this is with mypy 0.800 and numpy 1.19)

---

However, if I update numpy to 1.20 I get a number of errors that (as far as I can tell) have nothing to do with numpy (for both versions of mypy)

edit: not true, see below

---

On a related note: I think we should we add a full mypy run again? pre-commit only checks the files that are changed?

[mathause]

Sorry, I was wrong about (2) that has to do with numpy

edit: see #4878

[keewis]

pre-commit is run as pre-commit run --all-files, which will run the hooks on all files (unless we explicitly skip files using a pattern).

I do get the errors if I run python -m mypy xarray but not if I run python -m mypy . or pre-commit run --all-files, so I guess mypy cannot find the configuration file for mypy xarray. With mypy ., however, mypy will complain about a duplicated conftest.py.

[mathause]

Thanks, maybe we have to wait for mypy 0.810 then (or however they count). I am still a bit confused why this does not fail for numpy 1.20, though... or does this not install numpy etc?