Skip to content

Refactor apiv2.open_dataset #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2020
Merged

Refactor apiv2.open_dataset #4642

merged 4 commits into from
Dec 2, 2020

Conversation

aurghs
Copy link
Collaborator

@aurghs aurghs commented Dec 2, 2020 •
edited
Loading

Related to PR #4595.
In this smaller PR, there aren't changes functional changes, it's only a small code refactor needed to simplify #4595.
Changes in apiv2.dataset_from_backend_dataset:

  • rename ds in backend_ds and ds2 in ds.
  • simplify if in chunking and split code adding function _chunks_ds
  • add _get_mtime specific function

Make resolve_decoders_kwargs and dataset_from_backend_dataset private

@aurghs aurghs changed the title Refactor apiv2 open dataset Refactor apiv2.open_dataset Dec 2, 2020
@aurghs aurghs requested a review from alexamici December 2, 2020 11:24
@alexamici
Copy link
Collaborator

These are cosmetic changes to only the apiv2.py file and the Linux py38-backend-api-v2 pass, so I can merge them without much risk.

@alexamici alexamici merged commit 8ac3d86 into pydata:master Dec 2, 2020
@aurghs aurghs deleted the refactor_apiv2_open_dataset branch December 9, 2020 13:12
@aurghs aurghs restored the refactor_apiv2_open_dataset branch December 9, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexamici alexamici Awaiting requested review from alexamici

Assignees
No one assigned
Labels
grant-czi topic-backends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurghs @alexamici