change default in ds.chunk and datarray.chunk variable.chunk #4633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexamici
approved these changes
Dec 1, 2020
jhamman
reviewed
Dec 9, 2020
| if bad_dims: | ||
| raise ValueError( | ||
| "some chunks keys are not dimensions on this " "object: %s" % bad_dims | ||
| ) | ||
|
|
||
| variables = { | ||
| k: _maybe_chunk(k, v, chunks, token, lock, name_prefix) |
There was a problem hiding this comment.
The style checker is catching that name_prefix is not defined here.
There was a problem hiding this comment.
Yes, sorry, I deleted a line by mistake yesterday, when I have added the inline comment -_-'
|
Other than a small comment above, this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to split the PR #4595 in small PRs.
The scope of this smaller PR is to modify the default of
chunksindataset.chunkto align the behaviour toxr.open_dataset.The main changes are:
dataset.chunk,datarray.chunkandvariable.chunkfrom None to {}.chunk=Noneinside is set to{}Nonewill raise an error in the future.Note that the changes currently don't modify the behaviour of
dataset.chunkisort . && black . && mypy . && flake8