Remove maybe chunck duplicated function #4494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add in maybechunk the key overwrite_encoded_chunks for zarr
alexamici
reviewed
Oct 7, 2020
xarray/core/dataset.py
Outdated
| @@ -359,6 +359,39 @@ def _assert_empty(args: tuple, msg: str = "%s") -> None: | |||
| raise ValueError(msg % args) | |||
|
|
|||
|
|
|||
| def _selkeys(dict_, keys): | |||
There was a problem hiding this comment.
I see that you only moved this helper function out, but I would take the occasion to move the logic back into _maybe_chunk.
shoyer
approved these changes
Oct 8, 2020
|
@aurghs if you'd like to add an entry to whatsnew, please feel free. We'll plan to merge tomorrow. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this small change with a view to unifying in
open_datasetthe logic of zarr chunking with that of the other backends.Currently, the function
maybe_chunkis duplicated: it is defined inside the functiondataset.chunksand as method ofzarr.ZarrStore. This last function has been added with the recent merge of #4187 .I merged the two functions in a private function
_maybe_chunkinside the moduledataset.isort . && black . && mypy . && flake8