add a fallback_version to the setuptools_scm configuration #4358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
approved these changes
Aug 22, 2020
Contributor
crusaderky
left a comment
crusaderky
left a comment
There was a problem hiding this comment.
Tested, it works. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4299. While investigating version issues on RTD, I noticed that
setuptools_scmallows configuring its behavior, and the customtry: ... except ...clause can be replaced by settingfallback_version. The advantage is that once we switch topyproject.toml(for which we need to drop python 3.6), the changes are much more straightforward.cc @crusaderky