Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change isinstance checks to duck Dask Array checks #4208 #4221

Merged
merged 27 commits into from
Sep 2, 2020
Merged

Change isinstance checks to duck Dask Array checks #4208 #4221

merged 27 commits into from
Sep 2, 2020
+156 −103

Commits on Jul 13, 2020

  1. Change isinstance checks to duck Dask Array checks pydata#4208

    @rpmanser
    rpmanser committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    1d00df3 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Use is_dask_collection in is_duck_dask_array

    @rpmanser
    rpmanser committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    1ec28ec View commit details
    Browse the repository at this point in the history

  2. Use is_dask_collection in is_duck_dask_array

    @rpmanser
    rpmanser committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    817c35d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    03bfaa7 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Revert to isinstance checks according to review discussion

    @rpmanser
    rpmanser committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    bd770e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    299b518 View commit details
    Browse the repository at this point in the history

  2. Move is_duck_dask_array to pycompat.py and use tokenize for comparisons

    @rpmanser
    rpmanser committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    8ca52f6 View commit details
    Browse the repository at this point in the history

  3. isort

    @rpmanser
    rpmanser committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    e405c57 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    5b95264 View commit details
    Browse the repository at this point in the history

  2. Implement is_duck_array to replace is_array_like 

    * Rename `is_array_like` to `is_duck_array`

* `is_duck_array` checks for `__array_function__` and `__array_ufunc__`
  in addition to previous checks

* Replace checks for `is_duck_dask_array` and `__array_function__` with
  `is_duck_array`
    @rpmanser
    rpmanser committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    dcffe07 View commit details
    Browse the repository at this point in the history

  3. Skip numpy duck array tests when NEP18 is not active

    @rpmanser
    rpmanser committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    aacef50 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    37e766f View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Merge branch 'master' into issue4208

    @dcherian
    dcherian authored Aug 24, 2020
    Configuration menu
    Copy the full SHA
    13be9c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    457e36c View commit details
    Browse the repository at this point in the history

  2. Use utils.is_duck_array in xarray/core/formatting.py 

    * Replace locally defined `is_duck_array` in _diff_mapping_repr

* Replace `"__array_function__"` and `is_duck_dask_array` check in
  `short_data_repr`
    @rpmanser
    rpmanser committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    fd1db22 View commit details
    Browse the repository at this point in the history

  3. Revert back to isinstance check for iris cube

    @rpmanser
    rpmanser committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    3d81fcd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue4208' of https://github.com/rpmanser/xarray into i… 

    …ssue4208
    @rpmanser
    rpmanser committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    3337b6f View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    4bb8ca3 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Add is_duck_array_or_ndarray function to utils

    @rpmanser
    rpmanser committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    f2cbf1e View commit details
    Browse the repository at this point in the history

  2. Use is_duck_array_or_ndarray for duck array checks without NEP18

    @rpmanser
    rpmanser committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    d6189a9 View commit details
    Browse the repository at this point in the history

  3. Remove is_duck_dask_array_or_ndarray, replace checks with is_duck_array 

    * Add explicit check for NumPy array to is_duck_array

* Replace is_duck_array_or_ndarray checks with is_duck_array
    @rpmanser
    rpmanser committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    70fc50c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Remove is_duck_array check for deep copy 

    Co-authored-by: keewis <keewis@users.noreply.github.com>
    @rpmanser @keewis
    rpmanser and keewis authored Aug 29, 2020
    Configuration menu
    Copy the full SHA
    91c283a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'master' of https://github.com/pydata/xarray into issue4208

    @rpmanser
    rpmanser committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3cbcbb2 View commit details
    Browse the repository at this point in the history

  2. Use is_duck_array check in load

    @rpmanser
    rpmanser committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a51eb66 View commit details
    Browse the repository at this point in the history

  3. Move duck dask array tokenize tests from test_units.py to test_dask.py

    @rpmanser
    rpmanser committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    256d43d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'issue4208' of https://github.com/rpmanser/xarray into i… 

    …ssue4208
    @rpmanser
    rpmanser committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    80ddaa0 View commit details
    Browse the repository at this point in the history

  5. Use _importorskip to require pint >=0.15 instead of pytest.mark.skipif

    @rpmanser
    rpmanser committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    4e7409c View commit details
    Browse the repository at this point in the history