Skip to content

Remove broken test for Panel with to_pandas() #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2020
Merged

Remove broken test for Panel with to_pandas() #4028

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a320dff
Remove broken test for Panel with to_pandas()
shoyer May 4, 2020
969228e
remove unused import
shoyer May 4, 2020
2571860
Fixup LooseVersion import
shoyer May 5, 2020
31e7af1
Merge branch 'master' into remove-to_pandas-panel
shoyer May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions xarray/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@

from . import (
InaccessibleArray,
LooseVersion,
UnexpectedDataAccess,
assert_allclose,
assert_array_equal,
Expand Down Expand Up @@ -496,16 +495,11 @@ def test_constructor_pandas_single(self):
DataArray(np.random.rand(4, 3), dims=["a", "b"]), # df
]

if LooseVersion(pd.__version__) < "0.25.0":
das.append(DataArray(np.random.rand(4, 3, 2), dims=["a", "b", "c"]))

with warnings.catch_warnings():
warnings.filterwarnings("ignore", r"\W*Panel is deprecated")
for a in das:
pandas_obj = a.to_pandas()
ds_based_on_pandas = Dataset(pandas_obj)
for dim in ds_based_on_pandas.data_vars:
assert_array_equal(ds_based_on_pandas[dim], pandas_obj[dim])
for a in das:
pandas_obj = a.to_pandas()
ds_based_on_pandas = Dataset(pandas_obj)
for dim in ds_based_on_pandas.data_vars:
assert_array_equal(ds_based_on_pandas[dim], pandas_obj[dim])

def test_constructor_compat(self):
data = {"x": DataArray(0, coords={"y": 1}), "y": ("z", [1, 1, 1])}
Expand Down