Skip to content

Modify code in "Grouped arithmetic" #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Modify code in "Grouped arithmetic" #3904

merged 1 commit into from
Apr 5, 2020

Conversation

Hossein-Madadi
Copy link
Contributor

results.append(group - alt.sel(x=label)) must be changed to:
results.append(group - alt.sel(letters=label))

`results.append(group - alt.sel(x=label))` changed to:
`results.append(group - alt.sel(letters=label))`
@max-sixty
Copy link
Collaborator

Thanks @hoseinmadadi , good spot.

Want to add to whatsnew and give yourself credit?

@Hossein-Madadi
Copy link
Contributor Author

Hossein-Madadi commented Mar 27, 2020

@max-sixty, yes thanks, It will be my honor.

@max-sixty
Copy link
Collaborator

Great, ping when added and tests pass, thanks!

@max-sixty
Copy link
Collaborator

@hoseinmadadi do you want to add a line to the whatsnew file?

@shoyer
Copy link
Member

shoyer commented Apr 5, 2020

Let's just merge. I would always encourage contributors to give themselves credit, but in this case that's almost more of a burden than the fix itself :)

@hoseinmadadi thanks for the fix here! if you want to add a credit to yourself in whatsnew in a later PR, feel free!

@shoyer shoyer merged commit ba9f822 into pydata:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants