Conversation
keewis
reviewed
Mar 17, 2020
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
yeah, sorry about that. Most of the UnitStrippedWarnings should probably be filtered with pytest.filterwarnings("pint:::error") since they mean there's something going wrong, but we can only do that with numpy>=0.18 or pint>=0.11: before that numpy changed the behaviour of np.array when something raised a Warning in __array_interface__ or __array_struct__.
I'll submit a PR for that in the next few days.
Collaborator
|
Nice, thanks a lot @dcherian ! |
Co-Authored-By: keewis <keewis@users.noreply.github.com>
Contributor
Author
|
Thanks for the reviews @keewis and @max-sixty |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Mar 22, 2020
* upstream/master: add spacing in the versions section of the issue report (pydata#3876) map_blocks: allow user function to add new unindexed dimension. (pydata#3817) Delete associated indexes when deleting coordinate variables. (pydata#3840) remove macos build while waiting for libwebp fix (pydata#3875) Fix html repr on non-str keys (pydata#3870) Allow ellipsis to be used in stack (pydata#3826) Improve where docstring (pydata#3836) Add DataArray.pad, Dataset.pad, Variable.pad (pydata#3596) Fix some warnings (pydata#3864) Feature/weighted (pydata#2922) Fix recombination in groupby when changing size along the grouped dimension (pydata#3807) Blacken the doctest code in docstrings (pydata#3857) Fix multi-index with categorical values. (pydata#3860) Fix interp bug when indexer shares coordinates with array (pydata#3758) Fix alignment with join="override" when some dims are unindexed (pydata#3839)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's left is mostly a lot of
UnitStrippedWarnings. cc @keewis