-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strided rolling #3607
base: main
Are you sure you want to change the base?
Strided rolling #3607
Conversation
@niowniow I think Currently, we use 'bottleneck' if it is installed for speeding up nan-ops, but bottleneck does not support One way we could do is
In |
Is that still wanted? |
This PR adds a stride parameter to the rolling function of DataArray and Dataset . It basically extends the stride functionality being available for
core.rolling.DataArrayRolling.construct
andcore.rolling.DatasetRolling.construct
to the other methods ofDataArrayRolling
andDatasetRolling
.Note: it makes the arguments of
DataArrayRolling
andDatasetRolling
inconsistent with the respectiverolling
arguments of pandas Series and DataFrame (They do not support stride).Moreover, it does not solve the issue addressed in this pandas issue (Efficient stride computation).
black . && mypy . && flake8
whats-new.rst
for all changes andapi.rst
for new API