-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add DataArray.pad, Dataset.pad, Variable.pad #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7c230aa
add pad method to Variable and add corresponding test
mark-boer 5980234
move pad_with_fill value to dask_array_compat.py and make it default …
mark-boer b6a979b
add pad method to dataarray
mark-boer 80abc3a
add docstrings for variable.pad and dataarray.pad
mark-boer ed3d88e
add tests for DataArray.pad
mark-boer d4e484d
improve pad method signature and support dictionaries as pad_options …
mark-boer 65d7495
fix linting errors and remove typo from tests
mark-boer 0d7f1a7
implement suggested changes: pad_width => padwidths, use pytest.mark.…
mark-boer 1ee2950
move pad method to dataset
mark-boer 11023c3
add helper function to variable.pad and fix some mypy errors
mark-boer 3aae4ba
add some more tests for DataArray.pad and add docstrings to all pad m…
mark-boer 742487e
Merge branch 'master' into feature/dataarray_pad
mark-boer 314f007
add workaround for dask.pad mode=mean that converts integers to float…
mark-boer 7515478
disable linear_ramp test and add pad to whats-new.rst and api.rst
mark-boer ba3f0a4
Merge branch 'master' into feature/dataarray_pad
mark-boer 855c39e
fix small mege issue in test_unit
mark-boer d507d1d
fix DataArray.pad and Dataset.pad docstrings
mark-boer 64ac8a2
implement suggested changes from code review: add option of integer p…
mark-boer 71e11bb
apply isort and and set linear_ramp to xfail
mark-boer 7060b07
Minor fixes.
dcherian 588ff03
Merge remote-tracking branch 'upstream/master' into feature/dataarray…
mark-boer 3e6f792
fix merge issue and make some minor changes as suggested in the code …
mark-boer 6958da9
fix test_unit.test_pad_constant_values
mark-boer af0a4a1
Keewis review comments
dcherian f781f72
Add experimental warning
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.