Skip to content

Conversation

@gwgundersen
Copy link
Contributor

@gwgundersen gwgundersen commented Aug 27, 2019

  • Closes Building the docs creates temporary files #3227.
  • No CI tests added, but I ran make clean and make html to confirm the temporary files are no longer permanently created. I also confirmed the :suppress: blocks weren't showing up in the built HTML.
  • No need to pass black . && mypy . && flake8.
  • Fully documented in whats-new.rst.

@max-sixty max-sixty self-requested a review August 27, 2019 23:21
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @gwgundersen

@shoyer shoyer merged commit 8969b5a into pydata:master Aug 28, 2019
@shoyer
Copy link
Member

shoyer commented Aug 28, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building the docs creates temporary files

3 participants