Skip to content

Fix DataArray.groupby().reduce() mutating input array #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2018

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 22, 2018

Fixes GH2153

  • Closes Bug: side effect on method GroupBy.first  #2153 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@shoyer shoyer mentioned this pull request May 25, 2018
8 tasks
@shoyer shoyer merged commit 5ddfee6 into pydata:master May 29, 2018
@shoyer shoyer deleted the groupby-mutation branch May 29, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: side effect on method GroupBy.first
1 participant