Fix string slice indexing for a length-1 CFTimeIndex #2166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst
for all changes andapi.rst
for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)The issue is that both
is_monotonic_decreasing
andis_monotonic_increasing
returnTrue
for a length-1 index; therefore an additional check is needed to make sure the length of the index is greater than 1 inCFTimeIndex._maybe_cast_slice_bound
. This is similar to how things are done inDatetimeIndex._maybe_cast_slice_bound
in pandas.