Validate output dimension sizes with apply_ufunc #2155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH1931
Uses of apply_ufunc that change dimension size now raise an explicit error,
e.g.,
>>> xr.apply_ufunc(lambda x: x[:5], xr.Variable('x', np.arange(10)))
ValueError: size of dimension 'x' on inputs was unexpectedly changed by
applied function from 10 to 5. Only dimensions specified in ``exclude_dims``
with xarray.apply_ufunc are allowed to change size.
stickler-ci
reviewed
May 17, 2018
xarray/core/computation.py
Outdated
| for dim, new_size in var.sizes.items(): | ||
| if dim in dim_sizes and new_size != dim_sizes[dim]: | ||
| raise ValueError( | ||
| 'size of dimension {!r} on inputs was unexpectedly changed ' |
There was a problem hiding this comment.
E501 line too long (80 > 79 characters)
fujiisoup
reviewed
May 20, 2018
xarray/core/computation.py
Outdated
| result_data = [result_data] | ||
|
|
||
| output = [] | ||
| for dims, data in zip(output_dims, result_data): |
There was a problem hiding this comment.
I think it would be nice if we raise an informative error message when the number of output_dims and result_data is different.
Currently this will silently drop some items if they have a different number of items.
|
I plan to merge this shortly, unless anyone else has feedback here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1931
Uses of apply_ufunc that change dimension size now raise an explicit error,
e.g.,
whats-new.rstfor all changes andapi.rstfor new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)