Conversation
asv.conf.json uses the rattler environment type, whose plugin (py-rattler) is only in environment-benchmark.yml, so this workflow ran zero benchmarks. Also set pipefail so an asv failure is no longer hidden by the tee pipeline. Closes pydata#11533 Co-authored-by: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Automation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11533
The
Benchmark compare last releaseworkflow has been finishing green in ~30s without running a single benchmark.asv_bench/asv.conf.jsonmoved to"environment_type": "rattler"in #10866, andpy-rattlerwas added toci/requirements/environment-benchmark.yml. This workflow builds its environment fromci/requirements/environment.yml, which never gotpy-rattler, so asv exits with:That failure is invisible because the run step pipes
asv continuous ... | sed ... | tee benchmarks.logwithoutpipefail, and the only gate is a grep forTraceback \|failed\|PERFORMANCE DECREASED, which an environment-construction failure never matches.This switches the workflow to
environment-benchmark.yml(matchingbenchmarks.yml), renames the environment accordingly, addspython-buildtocreate-argsasbenchmarks.ymlalready does, and setspipefailso a failing asv run fails the job instead of being swallowed bytee.