Skip to content

Fix Pydap tests for numpy 2.3.0 changes (scalar string to unicode) #10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2025
Merged

Fix Pydap tests for numpy 2.3.0 changes (scalar string to unicode) #10421

merged 3 commits into from
Jun 13, 2025

Conversation

kmuehlbauer
Copy link
Contributor

  • Closes #xxxx
  • Tests fixed
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

kmuehlbauer
kmuehlbauer commented Jun 12, 2025
View reviewed changes
@kmuehlbauer
Copy link
Contributor Author

See #10395 for manifestation.

@kmuehlbauer
Copy link
Contributor Author

Missed one test to fix... 😞

dcherian
dcherian approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmuehlbauer kmuehlbauer changed the title Fix Pydap test_cmp_local_file for numpy 2.3.0 changes Fix Pydap tests for numpy 2.3.0 changes (scalar string to unicode) Jun 13, 2025
@kmuehlbauer kmuehlbauer merged commit 3610baa into pydata:main Jun 13, 2025
30 of 32 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-pydap branch June 13, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
topic-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmuehlbauer @dcherian