Skip to content

Should DataTree.orphan act in-place? #9674

Open
@TomNicholas

Description

@TomNicholas

What is your issue?

DataTree.orphan remove the parent node from a tree, but modifies in-place. It has no return value, so it's already consistent with #9196. But it's not obvious to me whether or not the method should return a modified copy instead.

came up here #9666 (comment)

cc @keewis @shoyer

Metadata

Metadata

Assignees

No one assigned

    Labels

    API designtopic-DataTreeRelated to the implementation of a DataTree class

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions