-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more frequency string updates? #8612
Comments
|
No strong view, but if we're just more permissive — forwarding almost anything to pandas — this gets around the issue. And doesn't involve writing translation code that will be removed fairly soon. |
If I understand correctly, the issue @mathause is noting is a bit more subtle. We already do forward to pandas by default for the standard calendar, but in this case pandas will raise an I think I am open to this, especially since we already introduced some translation logic as part of #8394; this refines that a bit more. It is nice though that pandas 2.2 was just released yesterday, which makes this less of an issue. |
👍 , thanks for the clear explanation Could I ask how close we are to fixing the other string issues — e.g. Should we ignore them in the doctests in the meantime? Or does changing the doctests to use the new string solve it? |
Indeed changing the doctests to use the new string should solve it (fortunately we don't have to worry about supporting multiple pandas versions there). I think this is already taken care of in #8638 (modulo including the updates in the generation file too). |
What is your issue?
I looked a bit into the frequency string update & found 3 issues we could improve upon.
Apart from
"M"
, pandas also deprecated"Y"
, and"Q"
, in favor of"YE"
and"QE"
. (And they are discussing renaming"MS"
to"MB"
). Should we do the same?Should we translate the new freq strings to the old ones if pandas < 2.2 is installed? Otherwise we get the following situation:
date_range_like
can emit deprecation warnings without a way to mitigate them if pandas < 2.2 is installed. (When aDatetimeIndex
) is passed. Could be nice to translate the old freq string to the new one without a warning.I have played around with 2. and 3. and can open a PR if you are on board.
@spencerkclark @aulemahal
The text was updated successfully, but these errors were encountered: