Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'name' an xray supported attribute? #679

Closed
max-sixty opened this issue Dec 15, 2015 · 2 comments
Closed

Is 'name' an xray supported attribute? #679

max-sixty opened this issue Dec 15, 2015 · 2 comments

Comments

@max-sixty
Copy link
Collaborator

If it is, a Dataset constructor should take a list of DataArrays, and use their names as keys? (and anywhere else you need to provide a dict-like mapping with names)

If it's not, we potentially shouldn't be using it in the internals.

I think it's the first, given it's in the docs (although not throughout the docs).

@shoyer
Copy link
Member

shoyer commented Dec 15, 2015

DataArray.name is a valid attribute -- it's filled in with the key corresponding to DataArrays in Datasets. Dataset.name is not valid. This is analogous to the situation on DataFrame and Series.

Converting a list of DataArrays into a Dataset does sound like a useful thing, but to me that functionality is would be a closer fit for a hypothetical merge function (#417). I was envisioning as taking a list of Dataset objects, but it would be straightforward to merge in DataArray objects, too.

@max-sixty
Copy link
Collaborator Author

Great, that's clear, cheers @shoyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants