Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider revising the _repr_inline_ protocol #5372

Open
shoyer opened this issue May 25, 2021 · 0 comments
Open

Consider revising the _repr_inline_ protocol #5372

shoyer opened this issue May 25, 2021 · 0 comments

Comments

@shoyer
Copy link
Member

shoyer commented May 25, 2021

_repr_inline_ looks like an IPython special method but is actually includes some xarray specific details: the result should not include shape or dtype.

As I wrote in #5352, I would suggest revising it in one of two ways:

  1. Giving it a name like _xarray_repr_inline_ to make it clearer that it's Xarray specific
  2. Include some more generic way of indicating that shape/dtype is redundant, e.g,. call it like obj._repr_ndarray_inline_(dtype=False, shape=False)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant