-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Description
Summary
Follow-up from PR #10742 (async DataTree loading optimization). As suggested by @keewis in the PR review:
logically I think
xr.open_datatree(...) == xr.DataTree.from_dict(xr.open_groups(...)), so it might make sense to have_open_datatree_asynccall_open_groups_as_dict_async
Current State
After #10742, the zarr backend has two similar async implementations:
_open_datatree_from_stores_async()- used byopen_datatree()open_groups_as_dict_async()- used byopen_groups()
Both do similar work but with some differences:
- Semaphore usage for concurrency control
- Index creation handling
Proposed Change
Refactor _open_datatree_from_stores_async to internally call open_groups_as_dict_async, reducing code duplication and ensuring consistent behavior between the two APIs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels