kwarg defaults (join="inner") for DataArray._binary_ops()

[chunweiyuan]

Currently the default is join="inner". However, there can be applications where the majority of binary operations require join="outer", not "inner".

Would it be advisable to place these default values in some config object the user can set at the beginning of the run script? Or perhaps one already exists but I've failed to locate it.

[shoyer]

Yes, we could make this a configurable option (currently it is not). See xarray.set_options for some related machinery.

[chunweiyuan]

Thanks. I will soon submit a pull request from my fork. Which branch should it go to? It seems that many people submit pull requests to master here.

[shoyer]

We submit PRs to master. Please also be sure to update Dataset binary ops,
too.

On Thu, Oct 27, 2016 at 1:55 PM, chunweiyuan notifications@github.com
wrote:

Thanks. I will soon submit a pull request from my fork. Which branch
should it go to? It seems that many people submit pull requests to master
here.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1059 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABKS1uoiRC1_HY1NQdIdO8aEhOq9gGHjks5q4Q_CgaJpZM4KfjtM
.

[chunweiyuan]

Yup, did that. Thank you. Will request to have you as a reviewer. Much obliged.

[stale]

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity
If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically