Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard access for scrollable regions created by notebook outputs #1787

Merged
merged 20 commits into from
May 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
221d4ec
Fix keyboard access for scrollable regions created by notebook outputs
gabalafou Apr 25, 2024
008cc9a
Remove data-tabindex, add test
gabalafou Apr 26, 2024
f759a69
Merge branch 'main' into fix-scrollable-notebook-outputs
Carreau May 21, 2024
6ac0dbb
[pre-commit.ci] Automatic linting and formatting fixes
pre-commit-ci[bot] May 21, 2024
f749d8b
mark as failing test instead of comment
Carreau May 22, 2024
8037ae3
Update tests/test_a11y.py
Carreau May 23, 2024
fe1c837
update comments
gabalafou May 23, 2024
b750602
Update tests/test_a11y.py
gabalafou May 23, 2024
dac259f
Merge branch 'main' into fix-scrollable-notebook-outputs
Carreau May 23, 2024
a8762a8
Add CSS to allow scrolling of ipywidget (#1760)
gabalafou May 23, 2024
2788f60
Fix keyboard access for scrollable regions created by notebook outputs
gabalafou Apr 25, 2024
ab616e6
Remove data-tabindex, add test
gabalafou Apr 26, 2024
e3b7dfc
mark tab stop tests as a11y
gabalafou May 24, 2024
a0dc755
[pre-commit.ci] Automatic linting and formatting fixes
pre-commit-ci[bot] May 24, 2024
658e099
fix bad rebase
gabalafou May 24, 2024
b44c530
call addTabStops after more important stuff
gabalafou May 24, 2024
a4b8b79
Update src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
gabalafou May 24, 2024
e9ca671
Update src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
gabalafou May 24, 2024
a583f6d
Update src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
gabalafou May 24, 2024
0740a28
Merge branch 'main' into fix-scrollable-notebook-outputs
gabalafou May 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
call addTabStops after more important stuff
  • Loading branch information
gabalafou committed May 24, 2024
commit b44c530e33b0fc11dd0120e5201078b07144b746
16 changes: 8 additions & 8 deletions src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
Original file line number Diff line number Diff line change
Expand Up @@ -720,14 +720,6 @@ function debounce(callback, wait) {
};
}

// Determining whether an element has scrollable content depends on stylesheets,
// so we're checking for the "load" event rather than "DOMContentLoaded"
if (document.readyState === "complete") {
addTabStopsToScrollableElements();
} else {
window.addEventListener("load", addTabStopsToScrollableElements);
}

/*******************************************************************************
* Announcement banner - fetch and load remote HTML
*/
Expand Down Expand Up @@ -799,3 +791,11 @@ documentReady(addTOCInteractivity);
documentReady(setupSearchButtons);
documentReady(initRTDObserver);
documentReady(setupMobileSidebarKeyboardHandlers);

// Determining whether an element has scrollable content depends on stylesheets,
// so we're checking for the "load" event rather than "DOMContentLoaded"
if (document.readyState === "complete") {
addTabStopsToScrollableElements();
} else {
window.addEventListener("load", addTabStopsToScrollableElements);
}
Loading