Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is always a scrollbar shown in the primary sidebar #1238

Open
FranzRoters opened this issue Mar 8, 2023 · 16 comments
Open

There is always a scrollbar shown in the primary sidebar #1238

FranzRoters opened this issue Mar 8, 2023 · 16 comments
Labels
tag: CSS CSS and SCSS related issues

Comments

@FranzRoters
Copy link

FranzRoters commented Mar 8, 2023

No matter how short the primary sidebar content is, I always get a scrollbar, even though it seems to be set to auto, as far as I understand the css code. Tested with 0.13.0 and 0.12.0.

@vkbo
Copy link
Contributor

vkbo commented Mar 10, 2023

I've noticed this as well. For me, it only shows up in Chrome, but looks fine in Firefox. It seems to me to be caused by the sidebar end section, because this custom css fixes it for me (I have no content in that section).

.sidebar-primary-items__end {
    margin-bottom: 0 !important;
    margin-top: 0 !important;
}

@FranzRoters
Copy link
Author

I get that behaviour in both Firefox and Edge on Windows.

The custom.css works for me with 0.13.0. Thanks vkbo.
I did not think about the sidebar end section as it is empty for me as well.

@12rambau
Copy link
Collaborator

12rambau commented Mar 11, 2023

is it a "y" scrollbar or a "x" scrollbar ?

@vkbo
Copy link
Contributor

vkbo commented Mar 11, 2023

It's vertical. At least it was in my case. Seemingly caused by the top and bottom margins of the __end box.

@FranzRoters
Copy link
Author

I was also referring to a y-scrollbar (vertical).

@12rambau
Copy link
Collaborator

ok perfect because we had another "x" scrollbar issue and I was sure it was solved with 0.13

@cbrnr
Copy link

cbrnr commented Jun 28, 2023

I have the same issue with Chrome and Safari (on macOS). Chrome renders a vertical sidebar, whereas Safari renders both vertical and horizontal scrollbars, even though the content easily fits into the available space. If it helps, I can post screenshots and/or margins/paddings for both browsers.

@cbrnr
Copy link

cbrnr commented Jun 28, 2023

Safari (showing mne.tools):

Screen.Recording.2023-06-28.at.13.56.22.mov

Chrome looks the same, but only shows the vertical scrollbar.

@12rambau
Copy link
Collaborator

Could you try it again with the main branch, we actually removed the custom scrollbar which may have solve this issue as a side effect.

@cbrnr
Copy link

cbrnr commented Jun 29, 2023

@ngulden
Copy link

ngulden commented Sep 14, 2023

I use version 0.13.3 and have the same observation in Chrome and Brave. The workaround from #1238 (comment) worked for me and the scrollbars disappear. Thanks.

Waiting for a new release so I can drop the workaround 😉

@adam-grant-hendry
Copy link

Linking sphinx-book-theme #732 to this issue as sphinx-book-theme appears affected downstream by pydata-sphinx-theme.

@adam-grant-hendry
Copy link

I still experience this issue on sphinx-book-theme==1.0.1.

@adam-grant-hendry
Copy link

adam-grant-hendry commented Sep 20, 2023

#1238 (comment) also worked for me (i.e. completely removed the scrollbar).

Follow-up: I don't mind the narrow scrollbar quite so much, but mine renders with an ugly large scrollbar like in sphinx-book-theme #732.

  1. Is anyone else suffering from this?
  2. Does anyone know how to make the scrollbar slim and dark until hovered like this?

@jamesdbrock
Copy link

I agree that #1238 (comment) is a good workaround. The problem is here:

image

@trallard trallard added the tag: CSS CSS and SCSS related issues label Sep 3, 2024
@DocOtak
Copy link

DocOtak commented Oct 11, 2024

In my own investigation I found this is being caused by the negative margins on the rtd-footer-container as noted by #1794

It looks like this div added in relation to work going on in #705 but I myself cannot find an example of content being moved to that rtd footer container. It's possible RTD changed how it injects the flyout, but I did not investigate, I'm willing to take a crack at a PR if given some guidance on direction.

There are a few solutions I can think of, but I don't know the intended direction of the maintainers. My mental box-model is also not the best.

  • Remove the negative margins from the style
  • Suppress that rtd-footer-container` div unless the site is being built on RTD
  • If that rtd-footer-container div is not being used maybe just remove it entirely

Carreau pushed a commit that referenced this issue Nov 12, 2024
Read the Docs recently rolled out its new "addons" project. This broke
assumptions made by code in our theme.

In particular, it means that all of the code that tries to move the Read
the Docs version switcher into the sidebar no longer works, so this pull
request removes all of that code and updates the docs.

I also removed the check for Read the Docs in the Ethical Ads template
because as far as I understand, that template is opt-in anyway, meaning
that sites that use our theme do not have that template included by
default.

Fixes #1794 and
possibly #1238.

This pull request does not address
#1933, which is
about providing a better integration with Read the Docs. The only goal
of this pull request is to remove code that is broken as a result of the
addons rollout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: CSS CSS and SCSS related issues
Projects
None yet
Development

No branches or pull requests

9 participants