-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is always a scrollbar shown in the primary sidebar #1238
Comments
I've noticed this as well. For me, it only shows up in Chrome, but looks fine in Firefox. It seems to me to be caused by the sidebar end section, because this custom css fixes it for me (I have no content in that section). .sidebar-primary-items__end {
margin-bottom: 0 !important;
margin-top: 0 !important;
} |
I get that behaviour in both Firefox and Edge on Windows. The custom.css works for me with 0.13.0. Thanks vkbo. |
is it a "y" scrollbar or a "x" scrollbar ? |
It's vertical. At least it was in my case. Seemingly caused by the top and bottom margins of the __end box. |
I was also referring to a y-scrollbar (vertical). |
ok perfect because we had another "x" scrollbar issue and I was sure it was solved with 0.13 |
I have the same issue with Chrome and Safari (on macOS). Chrome renders a vertical sidebar, whereas Safari renders both vertical and horizontal scrollbars, even though the content easily fits into the available space. If it helps, I can post screenshots and/or margins/paddings for both browsers. |
Safari (showing mne.tools): Screen.Recording.2023-06-28.at.13.56.22.movChrome looks the same, but only shows the vertical scrollbar. |
Could you try it again with the main branch, we actually removed the custom scrollbar which may have solve this issue as a side effect. |
Nope, this didn't change anything: https://output.circle-artifacts.com/output/job/f85ea057-af56-418e-9d53-abd191e8c936/artifacts/0/html/index.html |
I use version 0.13.3 and have the same observation in Chrome and Brave. The workaround from #1238 (comment) worked for me and the scrollbars disappear. Thanks. Waiting for a new release so I can drop the workaround 😉 |
Linking |
I still experience this issue on |
#1238 (comment) also worked for me (i.e. completely removed the scrollbar). Follow-up: I don't mind the narrow scrollbar quite so much, but mine renders with an ugly large scrollbar like in
|
I agree that #1238 (comment) is a good workaround. The problem is here: |
In my own investigation I found this is being caused by the negative margins on the It looks like this div added in relation to work going on in #705 but I myself cannot find an example of content being moved to that rtd footer container. It's possible RTD changed how it injects the flyout, but I did not investigate, I'm willing to take a crack at a PR if given some guidance on direction. There are a few solutions I can think of, but I don't know the intended direction of the maintainers. My mental box-model is also not the best.
|
Read the Docs recently rolled out its new "addons" project. This broke assumptions made by code in our theme. In particular, it means that all of the code that tries to move the Read the Docs version switcher into the sidebar no longer works, so this pull request removes all of that code and updates the docs. I also removed the check for Read the Docs in the Ethical Ads template because as far as I understand, that template is opt-in anyway, meaning that sites that use our theme do not have that template included by default. Fixes #1794 and possibly #1238. This pull request does not address #1933, which is about providing a better integration with Read the Docs. The only goal of this pull request is to remove code that is broken as a result of the addons rollout.
No matter how short the primary sidebar content is, I always get a scrollbar, even though it seems to be set to
auto
, as far as I understand the css code. Tested with 0.13.0 and 0.12.0.The text was updated successfully, but these errors were encountered: