Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove unused requests dependencies #574

Merged
merged 1 commit into from
Sep 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Up to date remote data access for pandas, works for multiple versions of pandas.

.. image:: https://img.shields.io/pypi/v/pandas-datareader.svg
:target: https://pypi.python.org/pypi/pandas-datareader/

.. image:: https://travis-ci.org/pydata/pandas-datareader.svg?branch=master
:target: https://travis-ci.org/pydata/pandas-datareader

Expand Down Expand Up @@ -72,8 +72,6 @@ Using pandas datareader requires the following packages:
* pandas>=0.19.2
* lxml
* requests>=2.3.0
* requests-file
* requests-ftp
* wrapt

Building the documentation additionally requires:
Expand Down
1 change: 1 addition & 0 deletions docs/source/whatsnew/v0.7.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,4 @@ Bug Fixes
- Fixed Yahoo! time offset (:issue:`487`).
- Fix Yahoo! quote reader (:issue: `540`)
- Remove import of deprecated `tm.get_data_path` (:issue: `566`)
- Removed unused requests-file and requests-ftp dependencies
4 changes: 0 additions & 4 deletions pandas_datareader/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import requests
from pandas import to_datetime
from pandas_datareader.compat import is_number
from requests_file import FileAdapter
from requests_ftp import FTPAdapter


class SymbolWarning(UserWarning):
Expand Down Expand Up @@ -42,7 +40,5 @@ def _sanitize_dates(start, end):
def _init_session(session, retry_count=3):
if session is None:
session = requests.Session()
session.mount('file://', FileAdapter())
session.mount('ftp://', FTPAdapter())
# do not set requests max_retries here to support arbitrary pause
return session
4 changes: 1 addition & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@ lxml
pandas>=0.19.2
pytest>=3
requests>=2.3.0
requests-file
requests-ftp
wrapt
# Documentation Only
matplotlib
ipython
sphinx
sphinx_rtd_theme
requests-cache
requests-cache
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def readme():


INSTALL_REQUIRES = (
['pandas>=0.19.2', 'requests>=2.3.0', 'requests-file', 'requests-ftp', 'wrapt', 'lxml']
['pandas>=0.19.2', 'requests>=2.3.0', 'wrapt', 'lxml']
)

setup(
Expand Down