Skip to content

New google urls #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2018
Merged

New google urls #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb54ebf
BUG: Change google URLS
bashtage Jan 20, 2018
833d6a3
TST: Makr test as xfail when market closed
bashtage Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas_datareader/google/daily.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __init__(self, symbols=None, start=None, end=None, retry_count=3,

@property
def url(self):
return 'http://finance.google.com/finance/historical'
return 'https://finance.google.com/finance/historical'

def _get_params(self, symbol):
params = {
Expand Down
2 changes: 1 addition & 1 deletion pandas_datareader/google/quotes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class GoogleQuotesReader(_BaseReader):

@property
def url(self):
return 'http://www.google.com/finance/info'
return 'https://finance.google.com/finance/info'

@property
def params(self):
Expand Down
5 changes: 4 additions & 1 deletion pandas_datareader/tests/test_iex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,7 @@ def test_live_prices(self):

def test_deep(self):
dob = get_iex_book('GS', service='book')
assert 'GS' in dob
if dob:
assert 'GS' in dob
else:
pytest.xfail(reason='Can only get Book when market open')