Skip to content

New FRED URL #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2018
Merged

New FRED URL #436

merged 1 commit into from
Jan 11, 2018

Conversation

jhoodsmith
Copy link

Updated url to reflect the changes by fred.stlouisfed.org for downloading CSV.

Updated url to reflect the changes by fred.stlouisfed.org for downloading CSV.
@bashtage
Copy link
Contributor

bashtage commented Jan 7, 2018

This looks right and the FRED tests pass

@rsvp rsvp mentioned this pull request Jan 7, 2018
@bashtage
Copy link
Contributor

Can you rebase on master? It should pass and then this can be merged.

@rsvp
Copy link

rsvp commented Jan 10, 2018

It is not clear whether the new URL scheme at FRED is stable.
For example, the default values on their qualifiers (see #435)
may change without notice to pandas_datareader users,
which will unexpectedly transform datasets.

The old URL is still operational, so it may be a good idea
to wait on the pull until the new FRED API is made "official."

@jhoodsmith
Copy link
Author

jhoodsmith commented Jan 10, 2018

For what it's worth, I agree with @rsvp. The new code is there if needed, but for the time being I suggest we follow the 'if it ain't broke, don't fix' strategy. Thank you to @bashtage for fixing the testing suite though.

@bashtage
Copy link
Contributor

The right way is https://research.stlouisfed.org/docs/api/fred/ but this requires an API key. The graph endpoint has been around for years and is used extensively through FRED to power the graphs.

@bashtage bashtage closed this Jan 10, 2018
@bashtage bashtage reopened this Jan 10, 2018
@bashtage
Copy link
Contributor

Accidental close.

@bashtage
Copy link
Contributor

Also worth noting that this new endpoint is where data comes from when one interactively downloads data.

@bashtage bashtage merged commit d71000d into pydata:master Jan 11, 2018
@bashtage
Copy link
Contributor

I'm going to merge this. I think it is the right endpoint since it is where data comes from when it is manually downloaded and there is no officially supported one.

@jhoodsmith jhoodsmith deleted the patch-1 branch January 11, 2018 10:27
@jhoodsmith jhoodsmith restored the patch-1 branch January 11, 2018 10:37
@jhoodsmith jhoodsmith deleted the patch-1 branch January 11, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants