Added data_source='yahoo-dividends' option to DataReader.
#138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you add a comment in the release note and reference in the docs? |
|
Can you also add a test please? |
|
Will do. |
|
Perfect, can you please squash and I will merge. |
… a test, docs, and whatsnew.
|
Squashed! |
|
Perfect, thanks for the contribution! |
davidastephens
added a commit
that referenced
this pull request
Dec 10, 2015
Added `data_source='yahoo-dividends'` option to DataReader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing dividend support pulls dividends as part of actions, but it's often desirable (for me anyway) to have just the dividends (and to pull a large number of symbols). The functionality is already there in
YahooDailyReader, and this PR just creates an option that exposes it inDataReader.