Skip to content

Can't convert string to float '1,006.73'  #345

Closed
@martinffx

Description

@martinffx

Amazon is too dam valuable!

>>> import pandas_datareader.data as web
>>>
>>> q = web.get_quote_google(['AMZN', 'GOOG'])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/data.py", line 56, in get_quote_google
    return GoogleQuotesReader(*args, **kwargs).read()
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/base.py", line 69, in read
    return self._read_one_data(self.url, self.params)
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/base.py", line 79, in _read_one_data
    return self._read_lines(out)
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/google/quotes.py", line 33, in _read_lines
    for x in result], columns=['change_pct',
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/google/quotes.py", line 33, in <listcomp>
    for x in result], columns=['change_pct',
ValueError: could not convert string to float: '1,006.73'

Should be a simple fix, I'll try my hand at it and submit a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions