Skip to content

Compare numpy version strings using pkg_resources.parse_version #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2015
Merged

Compare numpy version strings using pkg_resources.parse_version #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion numexpr/tests/test_numexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,8 @@ def test_multiprocess(self):

def print_versions():
"""Print the versions of software that numexpr relies on."""
if numpy.__version__ < minimum_numpy_version:
from pkg_resources import parse_version
if parse_version(numpy.__version__) < parse_version(minimum_numpy_version):
print("*Warning*: NumPy version is lower than recommended: %s < %s" % \
(numpy.__version__, minimum_numpy_version))
print('-=' * 38)
Expand Down