-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Duration parsing #35
Conversation
@samuelcolvin this blocks #34 which we want for Pydantic V2 Beta 3 pydantic/pydantic#6096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise idea looks good i think.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 99.50% 99.51% +0.01%
==========================================
Files 6 6
Lines 801 819 +18
==========================================
+ Hits 797 815 +18
Misses 4 4
Continue to review full report in Codecov by Sentry.
|
thanks so much. |
Fixes #34