Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in MultiHostUrl.build docstring #938

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Aug 31, 2023

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@Viicos
Copy link
Member Author

Viicos commented Aug 31, 2023

Please review

@Viicos Viicos changed the title Fix typo in PostgresDsn.build docstring Fix typo in MultiHostUrl.build docstring Aug 31, 2023
@hramezani
Copy link
Member

Thanks @Viicos

@hramezani hramezani enabled auto-merge (squash) August 31, 2023 13:34
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #938 (003ea4e) into main (01a1523) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files         105      105           
  Lines       15442    15442           
  Branches       25       25           
=======================================
  Hits        14489    14489           
  Misses        947      947           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a1523...003ea4e. Read the comment docs.

@hramezani hramezani merged commit 9ec1036 into pydantic:main Aug 31, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 31, 2023

CodSpeed Performance Report

Merging #938 will not alter performance

Comparing Viicos:patch-1 (003ea4e) with main (01a1523)

Summary

✅ 138 untouched benchmarks

@Viicos Viicos deleted the patch-1 branch August 31, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants