Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Apr 29, 2023

This PR has been adjusted to just be the changes to remove expect_fields_set - all typed dict validators inside a model validator must return fields set.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 29, 2023

CodSpeed Performance Report

Merging #565 custom_init (4c4fe8a) will not alter performances.

Summary

🔥 0 improvements
❌ 2 regressions
✅ 109 untouched benchmarks

🆕 0 new benchmarks
⁉️ 2 dropped benchmarks

Benchmarks breakdown

Benchmark main custom_init Change
test_model_instance 49.1 µs 54.1 µs -10.16%
test_model_instance_abc 49.9 µs 55.2 µs -10.53%
⁉️ test_core_python_not_fs 367.8 µs N/A N/A
⁉️ test_core_json_not_fs 799.2 µs N/A N/A

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Merging #565 (4c4fe8a) into main (cb42663) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   94.19%   94.20%           
=======================================
  Files          95       94    -1     
  Lines       12845    12762   -83     
  Branches       24       24           
=======================================
- Hits        12099    12022   -77     
+ Misses        740      734    -6     
  Partials        6        6           
Impacted Files Coverage Δ
pydantic_core/core_schema.py 96.86% <ø> (ø)
src/argument_markers.rs 87.87% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/validators/chain.rs 85.07% <ø> (-2.43%) ⬇️
src/validators/custom_error.rs 87.32% <ø> (-3.22%) ⬇️
src/validators/function.rs 90.59% <ø> (-0.49%) ⬇️
src/validators/generator.rs 93.23% <ø> (+2.19%) ⬆️
src/validators/json.rs 97.87% <ø> (-0.13%) ⬇️
src/validators/nullable.rs 100.00% <ø> (+7.69%) ⬆️
src/validators/typed_dict.rs 98.38% <ø> (-0.05%) ⬇️
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb42663...4c4fe8a. Read the comment docs.

@samuelcolvin samuelcolvin changed the title call custom __init__ method remove expect_fields_set Apr 30, 2023
@samuelcolvin
Copy link
Member Author

The regressions are just because these two tests had to have return_fields_set added to them.

@samuelcolvin samuelcolvin merged commit 4f1ce33 into main Apr 30, 2023
@samuelcolvin samuelcolvin deleted the custom_init branch April 30, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants