Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow function-wrap-schema to reuse parent schema #515

Merged
merged 6 commits into from
Apr 2, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Apr 2, 2023

avoid issues with cyclic references, and also with building unnecessarily big schemas.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Merging #515 (203557b) into main (cd5cd65) will increase coverage by 0.03%.
The diff coverage is 96.96%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   94.77%   94.80%   +0.03%     
==========================================
  Files          93       93              
  Lines       12262    12259       -3     
  Branches       25       25              
==========================================
+ Hits        11621    11622       +1     
+ Misses        634      630       -4     
  Partials        7        7              
Impacted Files Coverage Δ
src/validators/function.rs 96.05% <ø> (+0.20%) ⬆️
src/build_tools.rs 86.52% <90.00%> (+0.26%) ⬆️
pydantic_core/core_schema.py 96.74% <100.00%> (ø)
src/serializers/shared.rs 90.38% <100.00%> (ø)
src/serializers/type_serializers/function.rs 92.04% <100.00%> (+0.23%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5cd65...203557b. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2023

CodSpeed Performance Report

Merging #515 function-wrap-schema (203557b) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 95 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@samuelcolvin samuelcolvin force-pushed the function-wrap-schema branch from 669e8cc to da79ca6 Compare April 2, 2023 20:08
@samuelcolvin samuelcolvin enabled auto-merge (squash) April 2, 2023 20:12
@samuelcolvin samuelcolvin merged commit 1276e37 into main Apr 2, 2023
@samuelcolvin samuelcolvin deleted the function-wrap-schema branch April 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants