Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change args to list #508

Merged
merged 6 commits into from
Apr 1, 2023
Merged

Change args to list #508

merged 6 commits into from
Apr 1, 2023

Conversation

realDragonium
Copy link
Contributor

@realDragonium realDragonium commented Mar 31, 2023

Could this be the change requested by fix #446?

  • Changed all *args arguments from core_schema.py to use type list instead

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2023

CodSpeed Performance Report

Merging #508 realDragonium:change-args-to-list (8102d72) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 95 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@dmontagu
Copy link
Collaborator

@realDragonium yes, this is what @adriangb was talking about in that issue. Looks good to me but I'll defer to the others.

@codecov-commenter
Copy link

Codecov Report

Merging #508 (8102d72) into main (8b2be89) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   94.58%   94.59%   +0.01%     
==========================================
  Files          93       93              
  Lines       12014    12047      +33     
  Branches       25       25              
==========================================
+ Hits        11363    11396      +33     
  Misses        644      644              
  Partials        7        7              
Impacted Files Coverage Δ
pydantic_core/core_schema.py 96.74% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2be89...8102d72. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 227292b into pydantic:main Apr 1, 2023
@samuelcolvin
Copy link
Member

great, thank you so much.

@realDragonium realDragonium deleted the change-args-to-list branch April 2, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make union_schema and other functions that accept *args accept a list instead
4 participants