Skip to content

Conversation

art049
Copy link
Contributor

@art049 art049 commented Nov 22, 2022

As mentioned in #330 (comment)

I'm not sure it's the only source of randomness though but it should help in the result consistency.

@art049 art049 marked this pull request as ready for review November 22, 2022 17:23
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 22, 2022

CodSpeed Performance Report

Merging #338 fix-rng-seed (f0b8aaf) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 63 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #338 (f0b8aaf) into main (e146483) will decrease coverage by 0.78%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   97.16%   96.37%   -0.79%     
==========================================
  Files          57       57              
  Lines        6952     6899      -53     
  Branches       46       46              
==========================================
- Hits         6755     6649     -106     
- Misses        197      249      +52     
- Partials        0        1       +1     
Impacted Files Coverage Δ
pydantic_core/core_schema.py 89.06% <0.00%> (-10.94%) ⬇️
src/input/input_abstract.rs 87.23% <0.00%> (-3.20%) ⬇️
src/validators/recursive.rs 98.24% <0.00%> (-1.76%) ⬇️
src/validators/function.rs 98.33% <0.00%> (-0.56%) ⬇️
src/input/input_python.rs 98.12% <0.00%> (-0.23%) ⬇️
src/input/return_enums.rs 97.88% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e146483...f0b8aaf. Read the comment docs.

@samuelcolvin samuelcolvin enabled auto-merge (squash) November 22, 2022 22:20
@samuelcolvin samuelcolvin merged commit 85eb377 into pydantic:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants