Skip to content

Conversation

art049
Copy link
Contributor

@art049 art049 commented Nov 22, 2022

This will fix the benchmark results variability seen in #330 and #336.
It will probably create some regression since the core calling logic has been changed but this kind of refactoring affecting the results should be the last since the internal structure is now more modular.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 22, 2022

CodSpeed Performance Report

Merging #337 upgrade-pytest-codspeed-1-2-0 (d31327c) will not alter performances.

Summary

🔥 1 improvements
❌ 2 regressions
✅ 60 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main upgrade-pytest-codspeed-1-2-0 Change
test_core_python_not_fs 328.6 µs 361.8 µs -10.08%
🔥 test_many_models_core_model 100.4 ms 15 ms 85.10%
test_arguments 43.7 µs 49 µs -12.02%

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #337 (d31327c) into main (e146483) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          57       57           
  Lines        6952     6952           
  Branches       46       46           
=======================================
  Hits         6755     6755           
  Misses        197      197           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e146483...d31327c. Read the comment docs.

@art049 art049 marked this pull request as ready for review November 22, 2022 17:23
@samuelcolvin samuelcolvin merged commit 9f2cd67 into pydantic:main Nov 23, 2022
@samuelcolvin
Copy link
Member

Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants