Skip to content

Conversation

samuelcolvin
Copy link
Member

No description provided.

@samuelcolvin samuelcolvin enabled auto-merge (squash) November 16, 2022 15:17
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2022

CodSpeed Performance Report

Merging #334 ruff (873ad9f) will not alter performances.

Summary

🔥 2 improvements
❌ 0 regressions
✅ 61 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main ruff Change
🔥 test_many_models_core_model 99.8 ms 15.9 ms 84.04%
🔥 test_list_of_nullable_core 1,084.8 µs 916 µs 15.57%

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #334 (873ad9f) into main (1900f4a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          57       57           
  Lines        6890     6890           
  Branches       46       46           
=======================================
  Hits         6708     6708           
  Misses        182      182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1900f4a...873ad9f. Read the comment docs.

@samuelcolvin samuelcolvin merged commit bfe2d13 into main Nov 16, 2022
@samuelcolvin samuelcolvin deleted the ruff branch November 16, 2022 15:25
@samuelcolvin
Copy link
Member Author

@art049 there's no code changes in this pr, so the 84% change must be an artifact of how you're running or measuring the benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants