Skip to content

Conversation

samuelcolvin
Copy link
Member

wip

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #27 (9f38b37) into main (2fedd6c) will increase coverage by 3.38%.
The diff coverage is 66.33%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   64.64%   68.02%   +3.38%     
==========================================
  Files          22       22              
  Lines        1612     1648      +36     
==========================================
+ Hits         1042     1121      +79     
+ Misses        570      527      -43     
Impacted Files Coverage Δ
src/errors/kinds.rs 100.00% <ø> (ø)
src/errors/val_error.rs 0.00% <0.00%> (ø)
src/lib.rs 100.00% <ø> (ø)
src/validators/float.rs 11.76% <8.33%> (+0.54%) ⬆️
src/validators/int.rs 33.33% <18.75%> (ø)
src/input/json.rs 44.97% <27.41%> (+0.88%) ⬆️
src/input/python.rs 66.27% <53.65%> (+2.64%) ⬆️
src/validators/list.rs 60.31% <66.66%> (+2.50%) ⬆️
src/validators/union.rs 75.00% <66.66%> (ø)
src/validators/string.rs 83.20% <72.72%> (-0.38%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fedd6c...9f38b37. Read the comment docs.

* experimenting with references in errors

* avoid used of Onion input values

* remove InputValue, use Option

* call types passing!

* lazy errors fully working

* cleanup

* improve coverage
@samuelcolvin samuelcolvin changed the title Make erros lazier Make errors lazier Apr 24, 2022
@samuelcolvin samuelcolvin marked this pull request as ready for review April 24, 2022 14:59
@samuelcolvin samuelcolvin merged commit 7259e47 into main Apr 24, 2022
@samuelcolvin samuelcolvin deleted the lazy-errors branch April 24, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant