Skip to content

Conversation

samuelcolvin
Copy link
Member

With this we can set ref on every model etc. and not worry about performance - pydantic-core will only wrap validators in RecursiveContainerValidator when they're referenced elsewhere and therefore need to be stored in slots.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (146309f) to head (8b6cbcc).
Report is 989 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   98.63%   98.64%           
=======================================
  Files          49       49           
  Lines        5121     5149   +28     
  Branches       36       36           
=======================================
+ Hits         5051     5079   +28     
  Misses         70       70           
Files with missing lines Coverage Δ
src/validators/mod.rs 98.48% <100.00%> (+0.14%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146309f...8b6cbcc. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 373b6fa into main Sep 22, 2022
@samuelcolvin samuelcolvin deleted the recursive-ref-usage branch September 22, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants